src/rpc/methods/eth/trace/types.rs (1)

74-84: Consider adding a dedicated Unknown variant for unrecognized error strings.

The current fallback to ActorError(0) silently loses information when an unrecognized error string is encountered. While this is acceptable for round-tripping internally-produced data, a dedicated Unknown(String) variant would preserve the original error text and make debugging easier if unexpected strings appear.

💡 Optional: Add Unknown variant

 pub enum TraceError {
     // ... existing variants ...
     /// Actor-level error (catch-all for unrecognised exit codes).
     #[error("actor error: {}", ExitCode::from(*.0))]
     ActorError(u32),
+    /// Unknown error string that couldn't be parsed.
+    #[error("{0}")]
+    Unknown(String),
 }

Then in from_string:

                 } else {
-                    Self::ActorError(0)
+                    Self::Unknown(other.to_string())
                 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/rpc/methods/eth/trace/types.rs` around lines 74 - 84, The code currently
maps unrecognized error strings to ActorError(0); add a new enum variant
Unknown(String) to the enum in types.rs and update the from_string function to
return Self::Unknown(other.to_string()) in the final else branch (replacing
Self::ActorError(0)). Ensure references to the enum (e.g., in from_string, any
display/serialize helpers, and places that match on VmError/ActorError) are
updated to handle the Unknown(String) variant where appropriate so the original
error text is preserved.

src/rpc/methods/eth/trace/types.rs (1)

49-52: Avoid the extra allocation in Serialize.

serialize_str(&self.to_string()) still allocates a String for every serialized error. serializer.collect_str(self) writes the Display impl directly and keeps the allocation win from the typed representation.

♻️ Proposed fix

 impl Serialize for TraceError {
     fn serialize<S: serde::Serializer>(&self, serializer: S) -> Result<S::Ok, S::Error> {
-        serializer.serialize_str(&self.to_string())
+        serializer.collect_str(self)
     }
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/rpc/methods/eth/trace/types.rs` around lines 49 - 52, The Serialize impl
for TraceError currently allocates by calling self.to_string(); change the
serializer call inside impl Serialize for TraceError (the serialize method) to
use serializer.collect_str(self) so the Display impl is written directly without
creating an intermediate String; locate the Serialize impl for TraceError and
replace the serialize_str(&self.to_string()) usage accordingly.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes